-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for NewFilteredDynamicSharedInformerFactory #76776
Conversation
Hi @wwitzel3. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @lavalamp |
/ok-to-test is this not covered by a test? /assign @caesarxuchao |
/cc @yliaog |
/test pull-kubernetes-kubemark-e2e-gce-big |
staging/src/k8s.io/client-go/dynamic/dynamicinformer/informer_test.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/client-go/dynamic/dynamicinformer/informer_test.go
Outdated
Show resolved
Hide resolved
/retest Review the full test history for this PR. Silence the bot with an |
9 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest |
Signed-off-by: Wayne Witzel III <witzelw@vmware.com>
@lavalamp I had to fix the signature of a failing test, so it will need another review / approval. Cheers. |
/lgtm |
I asked in the #testing slack channel if pull-verify has got problems right now. |
/retest Review the full test history for this PR. Silence the bot with an |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
6 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
Signed-off-by: Wayne Witzel III witzelw@vmware.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adds tests to the fix for
NewFilteredDynamicSharedInformerFactory
.Which issue(s) this PR fixes:
Adds tests for #71714 which was fixed in #76776
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: